-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix span error tagging in GO YARPC/gRPC #2282
base: dev
Are you sure you want to change the base?
Conversation
kexiongliu123
commented
Aug 11, 2024
- Created span earlier and added missing span error tag
- Added span tag for gRPC status code(based on https://github.com/yarpc/yarpc-go/blob/dev/yarpcerrors/codes.go#L29)
- Added span tag for component
|
Also, do you have access to the builds? Circular dependency was introduced, code is uncompilable. |
LGTM, one test is failing though. |
api/transport/propagation.go
Outdated
// Returns the given error | ||
// UpdateSpanWithErr logs an error to the span. Prefer UpdateSpanWithErrAndCode | ||
// for including an error code in addition to the error message. | ||
// Deprecated: Use UpdateSpanWithErrAndCode instead. | ||
func UpdateSpanWithErr(span opentracing.Span, err error) error { | ||
if err != nil { | ||
span.SetTag("error", true) | ||
span.LogFields(opentracinglog.String("event", err.Error())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's correct the span log fields:
span.LogFields(
opentracinglog.String("event", "error"),
opentracinglog.String("message", err.Error()),
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, updated